Fix skipif for mkfifo usage in gh20582.phpt#20804
Conversation
Makes it like ext/standard/tests/file/filetype_variation.phpt; it's not just Windows that can have a missing posix_mkfifo, but also a minimal build, like the ones suggested that RMs (using --disable-all).
DanielEScherzer
left a comment
DanielEScherzer
left a comment
There was a problem hiding this comment.
Also failed when building PHP 8.5.2RC1 because the function was missing
|
As release managers we (@NattyNarwhal and I) should both have bypass rights, I see a "Merge without waiting for requirements to be met (bypass rules)" checkbox option |
The test doesn't seem to exist in PHP-8.2, so I made it target PHP-8.3. If the fix it's testing is present, should the whole test be backported to 8.2? |
|
NVM I was confusing this with another issue. This was indeed never fixed in <8.3. You're good to go. |
|
Merging this. Let me know if this is worth respinning an RC2 for, or if it should be included in the release branches. |
* PHP-8.3: Fix skipif for mkfifo usage in gh20582.phpt (#20804)
* PHP-8.4: Fix skipif for mkfifo usage in gh20582.phpt (#20804)
* PHP-8.5: Fix skipif for mkfifo usage in gh20582.phpt (#20804)
IMHO, worth being cherry-picked in release branches, but not worth a RC2 |
Makes it like ext/standard/tests/file/filetype_variation.phpt; it's not just Windows that can have a missing posix_mkfifo, but also a minimal build, like the ones suggested that RMs test with (using --disable-all). (cherry picked from commit bd484ed)
|
Cherry-picked to 8.5.2 as 9e111c1 |
Makes it like ext/standard/tests/file/filetype_variation.phpt; it's not just Windows that can have a missing posix_mkfifo, but also a minimal build, like the ones suggested that RMs test with (using --disable-all). (cherry picked from commit bd484ed)
|
Cherry picked to PHP-8.3.30 as 5b8c485 |
6 participants
Makes it like ext/standard/tests/file/filetype_variation.phpt; it's not just Windows that can have a missing posix_mkfifo, but also a minimal build, like the ones suggested that RMs test with (using --disable-all).